Update plugins SDK import path for restructured package#246
Conversation
WalkthroughThis PR updates plugin SDK import paths and refreshes module-related metadata: two internal files switch the plugin import from Changes
Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@internal/plugin/manager.go`:
- Line 24: The import pluginv1
("github.com/mozilla-ai/mcpd-plugins-sdk-go/pkg/plugins/v1") in
internal/plugin/manager.go is unresolvable with the current v0.0.2 module pin
(same issue as internal/plugin/adapter.go); update your module dependency to
v0.1.0 by bumping the version in go.mod and running `go mod tidy` to refresh
go.sum so the import resolves, then re-run `go build` to verify that references
to pluginv1 in manager.go (and adapter.go) compile successfully.
Update import path from: github.com/mozilla-ai/mcpd-plugins-sdk-go/pkg/plugins/v1/plugins to: github.com/mozilla-ai/mcpd-plugins-sdk-go/pkg/plugins/v1 The alias 'pluginv1' is preserved so no other code changes are needed. Requires mcpd-plugins-sdk-go v0.1.0 to be released first, at which point go.mod and NOTICE should also be updated.
Points to the restructured package commit (pseudo-version) until mcpd-plugins-sdk-go v0.1.0 is released, at which point this will be updated to the real tag.
peteski22
force-pushed
the
fix/plugins-sdk-import-path
branch
from
48a3e1a to
1b4fe03
Compare
peteski22
force-pushed
the
fix/plugins-sdk-import-path
branch
from
1b4fe03 to
6088f8a
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the import path for the mcpd-plugins-sdk-go package following a restructuring where the package path changed from .../pkg/plugins/v1/plugins to .../pkg/plugins/v1. The SDK version is also bumped from v0.0.2 to v0.1.0, bringing in various transitive dependency updates. Additionally, the Makefile and CI workflow files are corrected to use the proper module path without the /v2 suffix.
Changes:
- Updated import paths for mcpd-plugins-sdk-go from
.../pkg/plugins/v1/pluginsto.../pkg/plugins/v1while preserving thepluginv1alias - Bumped mcpd-plugins-sdk-go from v0.0.2 to v0.1.0 with corresponding transitive dependency updates
- Fixed Makefile MODULE_PATH and CI workflow references to remove incorrect
/v2suffix
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
internal/plugin/manager.go |
Updated import path for mcpd-plugins-sdk-go to new package structure |
internal/plugin/adapter.go |
Updated import path for mcpd-plugins-sdk-go to new package structure |
go.mod |
Bumped mcpd-plugins-sdk-go to v0.1.0 and updated transitive dependencies |
go.sum |
Updated checksums for mcpd-plugins-sdk-go v0.1.0 and all transitive dependencies |
NOTICE |
Removed old package entries and updated version references for golang.org/x packages |
Makefile |
Fixed MODULE_PATH from /v2 to match actual module path |
.github/workflows/validate-licenses.yaml |
Fixed module path references in license validation workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
.../pkg/plugins/v1/pluginsto.../pkg/plugins/v1pluginv1alias is preserved, so no other code changes are neededDependencies
go get github.com/mozilla-ai/mcpd-plugins-sdk-go@v0.1.0 && go mod tidyand regenerate NOTICETest plan
go build ./...andmake testpassSummary by CodeRabbit